Horton

Re: Typo in pg_db_role_setting.h

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Richard Guo <guofenglinux@gmail.com>
Cc: John Naylor <john.naylor@enterprisedb.com>, Japin Li <japinli@hotmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2022-08-02T07:45:36Z
Lists: pgsql-hackers 
> On 2 Aug 2022, at 09:37, Richard Guo <guofenglinux@gmail.com> wrote:

> The examples listed upthread all contain such comment in foo.h saying
> 'prototypes for functions in foo.c'.  For instance, in buffile.h, there is
> comment saying

> /*
>  * prototypes for functions in buffile.c
>  */
> 
> So if we remove such comments, should we also do so for those cases?

Comments which state the obvious are seldom helpful, I would prefer to remove
such comments and only explicitly call out the .c file in a comment when it's a
different basename from the header.

--
Daniel Gustafsson		https://vmware.com/

Commits

  1. Fix comment in pg_db_role_setting.h