Re: Fix REPACK with WITHOUT OVERLAPS replica identity indexes

Chao Li <li.evan.chao@gmail.com>

From: Chao Li <li.evan.chao@gmail.com>

To: Álvaro Herrera <alvherre@kurilemu.de>

Cc: Kirill Reshke <reshkekirill@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2026-05-11T06:54:18Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix REPACK with WITHOUT OVERLAPS replica identity indexes
- 36f52a59b315 19 (unreleased) landed
Remove working test that was supposed to fail
- 2fd787d0aac1 19 (unreleased) cited

Attachments

v3-0001-Fix-REPACK-with-WITHOUT-OVERLAPS-replica-identity.patch (application/octet-stream) patch v3-0001


> On May 10, 2026, at 06:38, Álvaro Herrera <alvherre@kurilemu.de> wrote:
> 
> On 2026-May-09, Chao Li wrote:
> 
>>> On May 9, 2026, at 01:47, Kirill Reshke <reshkekirill@gmail.com> wrote:
>>> 
>>> On Fri, 8 May 2026 at 09:22, Chao Li <li.evan.chao@gmail.com> wrote:
> 
>>>> While testing UPDATE FOR PORTION OF, I started wondering whether
>>>> REPACK supports temporal tables. In theory, it should, because
>>>> temporal WITHOUT OVERLAPS indexes can be used as replica identity
>>>> indexes. So I created a test script, repack_temporal.spec, which is
>>>> included in the attached patch, and it failed.
> 
> Nice find, thanks for testing.
> 
>>>> I found that REPACK hard-codes BTEqualStrategyNumber when calling
>>>> get_opfamily_member(). That seems wrong, because
>>>> build_replindex_scan_key() uses IndexAmTranslateCompareType() to
>>>> get the equality strategy for COMPARE_EQ.
> 
> Makes sense.
> 
> I think it would be a good idea to make identity_key_equal() not deform
> all attributes, but instead only up to the last one it needs for the key
> comparisons.
> 

That’s true. Please see v3.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/