Re: Fwd: lwlocknames.h beautification attempt

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Gurjeet Singh <gurjeet@singh.im>
Cc: Robert Haas <robertmhaas@gmail.com>, Álvaro Herrera <alvherre@alvh.no-ip.org>, Postgres Hackers <pgsql-hackers@postgresql.org>
Date: 2025-03-17T06:58:32Z
Lists: pgsql-hackers
Gurjeet Singh <gurjeet@singh.im> writes:
> On Sun, Mar 16, 2025 at 7:53 PM Robert Haas <robertmhaas@gmail.com> wrote:
>> I'm confused. Tom and I both said we didn't like this change,

> To me, Tom's feedback felt as being between ambivalent to the change and perhaps
> agree with the change, as long as pgindent did not throw a fit, which
> it did not.

Geez, are we really going to argue about whitespace in a generated
file?  But anyway, what I said was that I didn't like the style with
the define'd symbol right-justified, because it didn't look like
anything else in our code.  I'm entirely okay with the committed
version, which has plenty of precedent formatting-wise.

			regards, tom lane



Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Make lwlocknames.h generated file less ugly