WHERE CURRENT OF with RLS quals that are ctid conditions
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Cc: Robert Haas <robertmhaas@gmail.com>
Date: 2024-05-06T23:31:10Z
Lists: pgsql-hackers
Attachments
- v1-fix-CurrentOfExpr-with-RLS-TID-qual.patch (text/x-diff) patch v1
Robert pointed out [1] that the planner fails if we have $SUBJECT, because tidpath.c can seize on the RLS-derived ctid constraint instead of the CurrentOfExpr. Since the executor can only handle CurrentOfExpr in a TidScan's tidquals, that leads to a confusing runtime error. Here's a patch for that. However ... along the way to testing it, I found that you can only get such an RLS qual to work if it accepts "(InvalidBlockNumber,0)", because that's what the ctid field will look like in a not-yet-stored-to-disk tuple. That's sufficiently weird, and so unduly in bed with undocumented implementation details, that I can't imagine anyone is actually using such an RLS condition or ever will. So maybe this is not really worth fixing. Thoughts? regards, tom lane [1] https://www.postgresql.org/message-id/CA%2BTgmobwgL1XyV4uyUd26Nxff5WVA7%2B9XUED4yjpvft83_MBAw%40mail.gmail.com
Commits
-
Prevent RLS filters on ctid from breaking WHERE CURRENT OF <cursor>.
- 6572bd55b0a6 17.0 landed