Horton

Re: Comment for UserMappingPasswordRequired in contrib/postgres_fdw

Andreas Karlsson <andreas@proxel.se>

View thread View on postgr.es
From: Andreas Karlsson <andreas@proxel.se>
To: Etsuro Fujita <etsuro.fujita@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-02-18T20:30:06Z
Lists: pgsql-hackers 
On 2/18/26 9:23 PM, Etsuro Fujita wrote:
> I think the former part of the comment should be: Return *false* if
> the password_required is defined and false for this user mapping,
> otherwise *true*.
I feel the wording of the comment is pretty awkward both before and 
after your correctness fix. I am not a native speaker but shouldn't it 
be something like the below which explains better what is actually going on.

/*
  * Checks the value of password_required, defaults to true
  * if not defined. The mapping has been pre-validated.
  */

Andreas

Commits

  1. postgres_fdw: Fix thinko in comment for UserMappingPasswordRequired().