Re: Code cleanup patch submission for extended_stats.c
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <hornschnorter@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>,
Alvaro Herrera <alvherre@2ndquadrant.com>
Date: 2017-11-25T22:05:39Z
Lists: pgsql-hackers
Mark Dilger <hornschnorter@gmail.com> writes: > It looks to me like Alvaro introduced this in the original version of the file which > was created in commit 7b504eb282ca2f5104b5c00b4f05a3ef6bb1385b. Grep'ing > through the code base, it seems the following would be more consistent with > how these initializations are handled elsewhere: > memset(nulls, 1, sizeof(nulls)); > memset(replaces, 0, sizeof(replaces)); > memset(values, 0, sizeof(values)); +1. I'd be inclined to use "false" and "true" for the init values of the boolean arrays, too. regards, tom lane
Commits
-
Make memset() use sizeof() rather than re-compute size
- 3848d21673e9 11.0 landed
- cce3d72a8a42 10.2 landed
-
Implement multivariate n-distinct coefficients
- 7b504eb282ca 10.0 cited