Horton

Re: Obsolete comment in ExecInsert()

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-09-28T14:42:21Z
Lists: pgsql-hackers 
Etsuro Fujita <etsuro.fujita@gmail.com> writes:
> I think the “or a tuple has come for a different relation than that
> for the accumulated tuples" part in the comment is a leftover from an
> earlier version of the patch [1].  As the code shows, we do not handle
> that case anymore, so I think we should remove that part from the
> comment.  Attached is a patch for that.

+1, but what remains still seems awkwardly worded.  How about something
like "When we've reached the desired batch size, perform the insertion"?

			regards, tom lane

Commits

  1. Update comment in ExecInsert() regarding batch insertion.

  2. Implement support for bulk inserts in postgres_fdw