Re: BUG #16931: source code problem about commit_ts

Fujii Masao <masao.fujii@oss.nttdata.com>

From: Fujii Masao <masao.fujii@oss.nttdata.com>

To: Alvaro Herrera <alvherre@alvh.no-ip.org>

Cc: zoulx1982@163.com, pgsql-bugs@lists.postgresql.org

Date: 2021-03-24T10:25:54Z

Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove leftover dead code from commit_ts.h.
- c84698ceaea8 19 (unreleased) landed
Remove COMMIT_TS_SETTS record.
- 08aa89b32626 14.0 landed
Fix bug in WAL replay of COMMIT_TS_SETTS record.
- c29bab799c82 9.6.22 landed
- d544671f1572 10.17 landed
- 09cb8512ff11 11.12 landed
- 73cce168ffcb 12.7 landed
- 092c077c1321 13.3 landed
- 438fc4a39c39 14.0 landed

Attachments

v1_remove_commit_ts_setts.patch (text/plain) patch v1

On 2021/03/24 18:05, Alvaro Herrera wrote:
> Yeah, it seems like a bug.  With your patch, the write_xlog=true path
> becomes unused, and thus the whole COMMIT_TS_SETTS record, so we could
> remove those things in branch master.  The timestamp is acquired from
> the COMMIT record.

I agree to remove COMMIT_TS_SETTS record from the master branch
if there are no users or extensions of it. Patch attached.

Anyway, at first, what about applying the bugfix patch I posted upthread
to all supported branches?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION