Re: [BUG] segfault during delete

Drouvot, Bertrand <bdrouvot@amazon.com>

From: "Drouvot, Bertrand" <bdrouvot@amazon.com>
To: Amit Langote <amitlangote09@gmail.com>, Álvaro Herrera <alvherre@alvh.no-ip.org>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-03-04T07:17:04Z
Lists: pgsql-hackers
Thanks Amit and Alvaro for having helped to fix this bug so quickly.

Bertrand

On 3/1/21 3:22 AM, Amit Langote wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
> On Sun, Feb 28, 2021 at 6:14 AM Álvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>> Thanks Amit for working on this fix!  It seems correct to me, so I pushed it with trivial changes.  Thanks Bertrand for reporting the problem.
> Thanks Alvaro.
>
>> In addition to backpatching the code fix to pg12, I backpatched the test case to pg11. It worked fine for me (with no code changes), but it seems good to have it there just to make sure the buildfarm agrees with us on this.
> Ah, good call.
>
> --
> Amit Langote
> EDB: http://www.enterprisedb.com



Commits

  1. Fix use-after-free bug with AfterTriggersTableData.storeslot

  2. Use slots in trigger infrastructure, except for the actual invocation.