Horton
Menu

Re: Table AM modifications to accept column projection lists

Jacob Champion <pchampion@vmware.com>

View thread
From: Jacob Champion <pchampion@vmware.com>
To: "pryzby@telsasoft.com" <pryzby@telsasoft.com>, "soumyadeep2007@gmail.com" <soumyadeep2007@gmail.com>
Cc: "Ashwin Agrawal (Pivotal)" <aagrawal@pivotal.io>, "hlinnaka@iki.fi" <hlinnaka@iki.fi>, "sawada.mshk@gmail.com" <sawada.mshk@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, "melanieplageman@gmail.com" <melanieplageman@gmail.com>
Date: 2021-03-01T23:13:21Z
Lists: pgsql-hackers 
On Mon, 2021-03-01 at 16:59 -0600, Justin Pryzby wrote:
> -               pgstat_progress_update_param(PROGRESS_ANALYZE_CURRENT_CHILD_TABLE_RELID,                                                                                                                                           
> 
> -                                                                        RelationGetRelid(childrel));                                                                                                                              
> -                                                                                                                                                                                                                                  
> 
> Why is this removed ?

Mm, both of those analyze.c changes seem suspect. Possibly a mismerge
from the zedstore branch; let me double-check.

> 
> +                                * returningCols of it's base table's RTE.
> 
> its (possessive) not it's ("it is")

Thanks, I'll fix this at the same time.

--Jacob