Re: Not-terribly-safe checks for CRC intrinsic support

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Steven Niu <niushiji@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-17T02:13:01Z
Lists: pgsql-hackers
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Sunday, March 16, 2025, Steven Niu <niushiji@gmail.com> wrote:
>> +# is missing, we must link not just compile, and store the results in
>> global

> I’d probably add a comma before the “not” though.  Or maybe: we must also
> link and store the results in global

A comma there wouldn't be wrong, but in context that would make for
an overabundance of commas.  Or so it seems to me anyway.

> Doesn’t link imply compilation?

Yes.

			regards, tom lane



Commits

  1. Be more paranoid in configure's checks for CRC and POPCNT intrinsics.