Horton

Re: Simplify backend terminate and wait logic in postgres_fdw test

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Fujii Masao <masao.fujii@oss.nttdata.com>
Date: 2021-05-04T13:35:19Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> writes:
> (Worth noting that I am out this week for Golden Week, so if this can
> wait until Monday, that would be nice.  I am not willing to take my
> chances with the buildfarm now :p)

I will see to it.  I think it's important to get a fix in in the next
couple of days, because hyrax has not had a clean run in six weeks.
That animal takes almost a week per test cycle, so the next HEAD run
it starts (two or three days from now) is about our last chance to
get it to go green before beta1 wrap.  I feel it's fairly urgent to
try to do that, because who knows if any other cache-clobber issues
snuck in just before feature freeze.

			regards, tom lane

Commits

  1. Disable cache clobber to avoid breaking postgres_fdw termination test.

  2. Simplify tests of postgres_fdw terminating connections

  3. Add functions to wait for backend termination

  4. postgres_fdw: Fix tests for CLOBBER_CACHE_ALWAYS.