Horton
Menu

Re: [PATCH] clarify palloc comment on quote_literal_cstr

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Steve Chavez <steve@supabase.io>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2025-04-08T05:26:59Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> writes:
> Hmm.  I don't think that grouping all these details in the same
> comment block is an improvement in this case compared to the first
> version, where it is clear which part of the calculation applies to
> what.  In short, I'm OK with how things are on HEAD.

+1.  When I saw the patch I was mainly afraid that pgindent would
make a hash of it.  But it didn't, so I'm cool with it as-is.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Clarify comment for worst-case allocation in quote_literal_cstr()