Re: generate_series for timestamptz and time zone problem
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Przemysław Sztoch <przemyslaw@sztoch.pl>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2022-06-14T13:43:03Z
Lists: pgsql-hackers
=?UTF-8?Q?Przemys=c5=82aw_Sztoch?= <przemyslaw@sztoch.pl> writes: > Please let me know what is the convention (procedure) of adding new > functions to pg_proc. Specifically how oid is allocated. See https://www.postgresql.org/docs/devel/system-catalog-initial-data.html#SYSTEM-CATALOG-OID-ASSIGNMENT (you should probably read that whole chapter for context). > Therefore, should I add a second function timestamptz_pl_interval with > three arguments, or should a function with a different name be added so > that it does not get confused with operator functions (which only have > two arguments)? That's where you get into beauty-is-in-the-eye-of-the-beholder territory. There's some value in naming related functions alike, but on the other hand I doubt timestamptz_pl_interval would have been named so verbosely if anyone expected it to be called by name rather than via an operator. Coming up with good names is part of the work of preparing a patch like this. regards, tom lane
Commits
-
Add functions to do timestamptz arithmetic in a non-default timezone.
- 75bd846b68b0 16.0 landed
-
Refactor datetime functions' timezone lookup code to reduce duplication.
- 3e59e5048d0f 16.0 landed
-
Fix volatility marking of timestamptz_trunc_zone.
- 533e02e927c6 16.0 landed