Re: pg_upgrade failing for 200+ million Large Objects

Jan Wieck <jan@wi3ck.info>

From: Jan Wieck <jan@wi3ck.info>

To: Zhihong Yu <zyu@yugabyte.com>, Andrew Dunstan <andrew@dunslane.net>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Magnus Hagander <magnus@hagander.net>, Robins Tharakan <tharakan@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2021-03-22T23:18:33Z

Lists: pgsql-hackers

On 3/22/21 5:36 PM, Zhihong Yu wrote:
>     Hi,
> 
> w.r.t. pg_upgrade_improvements.v2.diff.
> 
> +       blobBatchCount = 0;
> +       blobInXact = false;
> 
> The count and bool flag are always reset in tandem. It seems 
> variable blobInXact is not needed.

You are right. I will fix that.


Thanks, Jan

-- 
Jan Wieck
Principle Database Engineer
Amazon Web Services

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Count individual SQL commands in pg_restore's --transaction-size mode.
- 81db073a2878 17.0 landed
- 0f1290521504 18.0 landed
Reduce number of commands dumpTableSchema emits for binary upgrade.
- b3f0e0503f33 18.0 landed
- 2fa989e6a340 17.0 landed
Invent --transaction-size option for pg_restore.
- 959b38d770ba 17.0 landed
Rearrange pg_dump's handling of large objects for better efficiency.
- a45c78e3284b 17.0 landed
Add temporal PRIMARY KEY and UNIQUE constraints
- 46a0cd4cefb4 17.0 cited
Fix typo and case in messages
- 7d7ef075d2b3 17.0 cited