Re: IPC::Run::time[r|out] vs our TAP tests
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, Erik Wienhold <ewie@ewie.name>, pgsql-hackers@lists.postgresql.org, Alexander Korotkov <aekorotkov@gmail.com>
Date: 2024-04-09T14:27:10Z
Lists: pgsql-hackers
On 2024-04-09 Tu 09:46, Tom Lane wrote: > Michael Paquier <michael@paquier.xyz> writes: >> By the way, are you planning to do something like [1]? I've not >> looked in details at the callers of IPC::Run::timeout, still the extra >> debug output would be nice. > It needs more review I think - I didn't check every call site to see > if anything would be broken. I believe Andrew has undertaken a > survey of all the timeout/timer calls, but if he doesn't produce > anything I might have a go at it after awhile. > > What I looked at so far was the use of is_expired, but when you look into that you see that you need to delve further, to where timeout/timer objects are created and passed around. I'll take a closer look when I have done some incremental json housekeeping. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
Commits
-
Restart BackgroundPsql's timer more nicely.
- 53c6bd0aa3de 19 (unreleased) landed
-
Implement pg_wal_replay_wait() stored procedure
- 3c5db1d6b016 18.0 cited
-
psql: fix variable existence tab completion
- 927332b95e77 17.0 cited