Horton
Menu

Re: pg_dump --with-* options

Jeff Davis <pgsql@j-davis.com>

View thread
From: Jeff Davis <pgsql@j-davis.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-08-02T15:30:07Z
Lists: pgsql-hackers 
On Fri, 2025-08-01 at 17:46 -0500, Nathan Bossart wrote:
> On Fri, Aug 01, 2025 at 12:42:16PM -0700, Jeff Davis wrote:
> > -      <term><option>--with-statistics</option></term>
> > +      <term><option>--statistics</option></term>
> 
> > -      <term><option>--with-statistics</option></term>
> > +      <term><option>--statistics</option></term>
> 
> > -      <term><option>--with-statistics</option></term>
> > +      <term><option>--statistics</option></term>
> 
> nitpick: --statistics should be moved to maintain alphabetical
> ordering.
> 

Thank you. I committed this and closed the Open Item.

I did not address the following issues:

  * Did not change default to on: there was no consensus on this point,
and the default-off opinions were stronger. We may be able to revisit
for PG19.
  * Did not add --include syntax: no patch and no consensus on the
details.
  * Did not remove redundant --no-statistics option for pg_dump and
redundant --statistics option for pg_restore: kept for consistency
between pg_dump and pg_restore, and to allow us to potentially change
to default-on in the future.

If someone feels one of these needs to be addressed in PG18, let me
know.

Regards,
	Jeff Davis

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Simplify options in pg_dump and pg_restore.

  2. pg_dump: reject combination of "only" and "with"

  3. Change pg_dump default for statistics export.