Re: Use of backup_label not noted in log
David Steele <david@pgmasters.net>
From: David Steele <david@pgmasters.net>
To: Michael Banck <mbanck@gmx.net>
Cc: Michael Paquier <michael@paquier.xyz>, Andres Freund
<andres@anarazel.de>, Pg Hackers <pgsql-hackers@postgresql.org>,
Laurenz Albe <laurenz.albe@cybertec.at>
Date: 2024-01-25T21:37:18Z
Lists: pgsql-hackers
On 1/25/24 09:29, Michael Banck wrote: > Hi, > > On Thu, Jan 25, 2024 at 08:56:52AM -0400, David Steele wrote: >> I would still advocate for a back patch here. It is frustrating to get logs >> from users that just say: >> >> LOG: invalid checkpoint record >> PANIC: could not locate a valid checkpoint record >> >> It would be very helpful to know what the checkpoint record LSN was in this >> case. > > I agree. Another thing to note here -- knowing the LSN is important but also knowing that backup recovery was attempted (i.e. backup_label exists) is really crucial. Knowing both just saves so much time in back and forth debugging. It appears the tally for back patching is: For: Andres, David, Michael B Not Sure: Robert, Laurenz, Michael P It seems at least nobody is dead set against it. Regards, -David
Commits
-
Add more LOG messages when starting and ending recovery from a backup
- 8b34cff3381a 15.6 landed
- edbd1b41ab5b 16.2 landed
- 1d35f705e191 17.0 landed