Horton

Re: BUG: pg_stat_statements query normalization issues with combined queries

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Craig Ringer <craig.ringer@2ndquadrant.com>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-01-14T21:18:49Z
Lists: pgsql-hackers 
Fabien COELHO <coelho@cri.ensmp.fr> writes:
>> It ends up being about 30 fewer lines of code overall, despite there 
>> being four places that have to make ad-hoc RawStmt nodes.  On the whole 
>> I feel like this is cleaner,

> I agree: Better typing, more homogeneous code (PlannedStmt for all), 
> less ad-hoc checks to work around utility statements...

OK, pushed like that.

			regards, tom lane

Commits

  1. Teach contrib/pg_stat_statements to handle multi-statement commands better.

  2. Change representation of statement lists, and add statement location info.

  3. Revert my bad decision of about a year ago to make PortalDefineQuery