Horton

Thread

Commits

  1. Fix function name in error hint

  1. hint Consider using pg_file_read()

    Sergei Kornilov <sk@zsrv.org> — 2021-03-18T09:57:46Z

    Hello
In src/backend/utils/adt/genfile.c in pg_read_file we have errhint

> errhint("Consider using %s, which is part of core, instead.",
>						 "pg_file_read()")

Shouldn't pg_read_file() be written here?

regards, Sergei

  2. Re: hint Consider using pg_file_read()

    Magnus Hagander <magnus@hagander.net> — 2021-03-18T10:21:45Z

    On Thu, Mar 18, 2021 at 10:58 AM Sergei Kornilov <sk@zsrv.org> wrote:
>
> Hello
> In src/backend/utils/adt/genfile.c in pg_read_file we have errhint
>
> > errhint("Consider using %s, which is part of core, instead.",
> >                                                "pg_file_read()")
>
> Shouldn't pg_read_file() be written here?

Yup, it certainly looks that way. There's a really funky combination
of names between SQL and backend there that I guess threw the original
author off.

Will fix.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/

  3. Re: hint Consider using pg_file_read()

    Sergei Kornilov <sk@zsrv.org> — 2021-03-18T10:44:40Z

    I noticed that the fix has been committed, thank you!

regards, Sergei