Horton

Re: Built-in CTYPE provider

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Noah Misch <noah@leadboat.com>, Laurenz Albe <laurenz.albe@cybertec.at>, Peter Eisentraut <peter@eisentraut.org>, Daniel Verite <daniel@manitou-mail.org>, Jeremy Schneider <schneider@ardentperf.com>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Date: 2024-07-18T17:03:31Z
Lists: pgsql-hackers 
Jeff Davis <pgsql@j-davis.com> writes:
> On Thu, 2024-07-18 at 07:00 -0700, Noah Misch wrote:
>> Maybe someone will change
>> something in v18 so it's not like that, but don't count on it.

> That's backwards. If nothing happens in v18, then there will be no
> breaking Unicode change. It takes an active step by a committer to
> update Unicode.

This whole discussion seems quite bizarre to me.  In the first
place, it is certain that Unicode will continue to evolve, and
I can't believe that we'd just freeze pg_c_utf8 on the current
definition forever.  Whether the first change happens in v18
or years later doesn't seem like a particularly critical point.

In the second place, I cannot understand why pg_c_utf8 is being
held to a mutability standard that we have never applied to any
other locale-related functionality --- and indeed could not do
so, since in most cases that functionality has been buried in
libraries we don't control.  It seems to me to be already a
great step forward that with pg_c_utf8, at least we can guarantee
that the behavior won't change without us knowing about it.
Noah's desire to revert the feature makes the mutability situation
strictly worse, because people will have to continue to rely on
OS-provided functionality that can change at any time.

			regards, tom lane

Commits

  1. Support PG_UNICODE_FAST locale in the builtin collation provider.

  2. Support Unicode full case mapping and conversion.

  3. Fix test failures when language environment is not UTF-8.

  4. Add unicode_strtitle() for Unicode Default Case Conversion.

  5. Use version for builtin collations.

  6. Fix convert_case(), introduced in 5c40364dd6.

  7. Inline basic UTF-8 functions.

  8. Support C.UTF-8 locale in the new builtin collation provider.

  9. Fix another warning, introduced by 846311051e.

  10. Address more review comments on commit 2d819a08a1.

  11. Fix unreachable code warning from commit 2d819a08a1.

  12. Introduce "builtin" collation provider.

  13. Catalog changes preparing for builtin collation provider.

  14. Unicode case mapping tables and functions.

  15. Add Unicode property tables.

  16. Documentation update for Standard Collations.

  17. Cleanup for unicode-update build target and test.

  18. Shrink Unicode category table.

  19. Make some error strings more generic

  20. pg_upgrade: copy locale and encoding information to new cluster.

  21. Update Unicode data to Unicode 15.0.0

  22. Create a new type category for "internal use" types.