Re: Clear base backup progress reporting on error
Chao Li <li.evan.chao@gmail.com>
From: Chao Li <li.evan.chao@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-26T11:08:17Z
Lists: pgsql-hackers
> On Jun 26, 2026, at 18:46, Fujii Masao <masao.fujii@gmail.com> wrote: > > On Fri, Jun 26, 2026 at 5:59 PM Chao Li <li.evan.chao@gmail.com> wrote: >> This patch makes the following changes: > > Thanks for the report and patch! > >> I don’t think this is a serious bug, because with the usual pg_basebackup command path, the client normally disconnects after the error, so the stale progress entry is not observable. It is mainly visible when the same replication connection stays open after the failed BASE_BACKUP command. So I feel it might not be worth adding a TAP test. > > +1 > > You may think this isn't worth backpatching to the stable branches > for the same reason? > I personally don’t feel back-patch is needed. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
Commits
-
Clear base backup progress on backup failure
- cf7530cf758a 15 (unreleased) landed
- 7cbd80340b4a 16 (unreleased) landed
- e2ea6bfed880 17 (unreleased) landed
- e7564ee8cdcb 18 (unreleased) landed
- b70000837888 19 (unreleased) landed
- 55f0a13e96be master landed