Horton

Re: Converting contrib SQL functions to new style

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ronan Dunklau <ronan.dunklau@aiven.io>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Date: 2024-12-29T20:01:16Z
Lists: pgsql-hackers 
I wrote:
> I reviewed and pushed these.  Let's not forget that the pageinspect
> one is still pending, though.  We were waiting on Tomas' fix, which
> is now pushed at 957ba9ff1, so I suppose it needs a rebase.

Actually ... that one's quite trivial, so I went ahead and pushed it.

The submitted patch had the functions as PARALLEL SAFE, but I think
they have to remain PARALLEL RESTRICTED because they use
tuple_data_split(), cf pageinspect--1.10--1.11.sql.

			regards, tom lane

Commits

  1. Use @extschema:name@ notation in contrib transform modules.

  2. pg_freespacemap: Fix declaration of pg_freespace(regclass)

  3. contrib/pageinspect: Use SQL-standard function bodies.

  4. contrib/xml2: Use SQL-standard function bodies.

  5. contrib/citext: Use SQL-standard function bodies.

  6. contrib/earthdistance: Use SQL-standard function bodies.

  7. contrib/lo: Use SQL-standard function bodies

  8. xml2: Add tests for functions xpath_nodeset() and xpath_list()

  9. contrib/lo: Add test for function lo_oid()

  10. pg_freespacemap: Use SQL-standard function bodies

  11. Add @extschema:name@ and no_relocate options to extensions.

  12. Make contrib modules' installation scripts more secure.