Re: Assorted improvements in pg_dump

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Justin Pryzby <pryzby@telsasoft.com>

Cc: Hans Buschmann <buschmann@nidsa.net>, pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>

Date: 2021-10-24T22:58:41Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pg_dump: avoid unsafe function calls in getPolicies().
- b7333e826955 11.19 landed
- a5b26aaafe4f 13.10 landed
- 1ed6f1b9116c 12.14 landed
- 03ac48549438 14.7 landed
- 3e6e86abca01 15.0 landed
Postpone calls of unsafe server-side functions in pg_dump.
- e46e986baef0 13.10 landed
- b1f106420b1a 11.19 landed
- 55f30e6c7640 14.7 landed
- 344b7849200f 12.14 landed
- e3fcbbd623b9 15.0 landed
Account for TOAST data while scheduling parallel dumps.
- 65aaed22a849 15.0 landed
Use PREPARE/EXECUTE for repetitive per-object queries in pg_dump.
- be85727a3df7 15.0 landed
Avoid per-object queries in performance-critical paths in pg_dump.
- 9895961529ef 15.0 landed
Rethink pg_dump's handling of object ACLs.
- 0c9d84427f44 15.0 landed
Refactor pg_dump's tracking of object components to be dumped.
- 5209c0ba0bfd 15.0 landed
pg_dump: fix mis-dumping of non-global default privileges.
- 2acc84c6fd29 15.0 cited

Justin Pryzby <pryzby@telsasoft.com> writes:
> On Sun, Oct 24, 2021 at 05:10:55PM -0400, Tom Lane wrote:
>> +               if (tbloids->len > 1)

> I think this should say 
> +               if (tbloids->len > 0)

No, >1 is the correct test, because it's checking the string length
and we started by stuffing a '{' into the string.  Maybe needs a
comment.

> BTW, the ACL patch makes the overhead 6x lower (6.9sec vs 1.2sec) for pg_dump -t
> of a single, small table.  Thanks for that.

Yeah --- I haven't done any formal measurements of the case where you're
selecting a small number of tables, but I did note that it decreased a
good deal compared to HEAD.

			regards, tom lane