Re: bugfix - plpgsql - statement counter is incremented 2x for FOR stmt
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2021-02-02T19:36:19Z
Lists: pgsql-hackers
Pavel Stehule <pavel.stehule@gmail.com> writes: > When I fixed one plpgsql_check issue, I found another plpgsql issue. Now we > have field nstatements that hold a number of plpgsql statements in > function. Unfortunately I made an error when I wrote this functionality and > for FOR statements, this counter is incremented 2x. Higher number than a > real number is better than a lesser number, but it can be a source of > problems too (inside plpgsql_check I iterate over 0 .. nstatements stmtid, > and due this bug I had a problem with missing statements). > Attached patch is pretty simple: Right, done. regards, tom lane
Commits
-
Remove extra increment of plpgsql's statement counter for FOR loops.
- 78fab843386b 12.6 landed
- 0fe8b1f7d48e 13.2 landed
- dfcc46fe3030 14.0 landed