Thread

Re: [Bug][patch]: After dropping the last label from a property graph element, invoking pg_get_propgraphdef() triggers an assertion failure

Peter Eisentraut <peter@eisentraut.org> — 2026-05-04T14:46:21Z

On 28.04.26 17:02, Ashutosh Bapat wrote:
> We are looking up element label catalogs twice in this patch - first
> to find the label to be dropped and then to find the number of labels
> associated with the given element. I combined these two into a single
> while loop.

That looks okay, but I think the names of the local variables are now a 
bit off.  I would expect elrel and elscan to refer to 
pg_propgraph_element, not pg_propgraph_element_label.  Maybe use 
ellabelrel etc.

Also, I think this code needs to think a bit about locking to handle the 
situation where more than one DROP LABEL operation happens concurrently.