Horton
Menu

Re: SIMILAR TO expressions translate wildcards where they shouldn't

Laurenz Albe <laurenz.albe@cybertec.at>

View thread
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-bugs@lists.postgresql.org
Date: 2025-05-27T10:24:33Z
Lists: pgsql-bugs 
On Tue, 2025-05-27 at 14:57 +0900, Michael Paquier wrote:
> Anyway, that's really hard to parse so I would suggest to split each
> check into queries of their own to show individual conversions in
> these EXPLAIN outputs (we don't care if tese regexps are correct, just
> want to check the output to the POSIX style).  I am OK with the point
> based on charclass_start to count the number of carets at the
> beginning of a character class.
> 
> With some tweaks and the tests reworked, I am finishing with the
> reviewed version attached.  What do you think?

Thank you; I think that is good to go.

Yours,
Laurenz Albe

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Adjust regex for test with opening parenthesis in character classes

  2. Fix conversion of SIMILAR TO regexes for character classes