Re: Converting SetOp to read its two inputs separately

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es

From: Tom Lane <tgl@sss.pgh.pa.us>

To: David Rowley <dgrowleyml@gmail.com>

Cc: Richard Guo <guofenglinux@gmail.com>, pgsql-hackers@lists.postgresql.org

Date: 2024-12-19T19:38:14Z

Lists: pgsql-hackers

Attachments

v5-0001-Convert-SetOp-to-read-its-inputs-as-outerPlan-and.patch (text/x-diff) patch v5-0001
v5-0002-Remove-some-dead-code-in-prepunion.c.patch (text/x-diff) patch v5-0002
v5-0003-Get-rid-of-choose_hashed_setop.patch (text/x-diff) patch v5-0003
v5-0004-Fix-bogus-decisions-about-whether-we-want-pre-sor.patch (text/x-diff) patch v5-0004
v5-0005-Teach-generate_nonunion_paths-to-consider-pre-sor.patch (text/x-diff) patch v5-0005
v5-0006-Use-ExecGetCommonSlotOps-infrastructure-in-more-p.patch (text/x-diff) patch v5-0006

David Rowley <dgrowleyml@gmail.com> writes:
> On Thu, 19 Dec 2024 at 15:44, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The common_result_slot_type() function I wrote here perhaps
>> should be made generally available, but I didn't do that yet.

> I think it would be good to make this generic as it can be at least
> used in nodeRecursiveunion.c and nodeAppend.c.

OK, done, and I added an 0006 patch that uses that infrastructure
in the obvious places.

I also addressed your remarks about comments.  Otherwise I'm feeling
like this is about ready to push.

			regards, tom lane

Commits

Get rid of old version of BuildTupleHashTable().
- e0a2721f7c16 18.0 landed
Use ExecGetCommonSlotOps infrastructure in more places.
- f0b900086a37 18.0 landed
Improve planner's handling of SetOp plans.
- 8d96f57d5cc7 18.0 landed
Convert SetOp to read its inputs as outerPlan and innerPlan.
- 27627929528e 18.0 landed
Fix typo in header comment for set_operation_ordered_results_useful
- b6612aedc53a 18.0 landed
Allow planner to use Merge Append to efficiently implement UNION
- 66c0185a3d14 17.0 cited