Horton

Thread

Commits

  1. Fix typo in JIT README.

  1. JIT documentation fixes

    Daniel Gustafsson <daniel@yesql.se> — 2018-05-31T18:50:04Z

    When reading the JIT developer documentation, a few small wordsmithing issues
stood out (although this may be due to me not being a native english speaker).
The attached patch fixes these to what I think the sentences inteded to say.

cheers ./daniel

  2. Re: JIT documentation fixes

    Andres Freund <andres@anarazel.de> — 2018-05-31T19:01:18Z

    On 2018-05-31 14:50:04 -0400, Daniel Gustafsson wrote:
> When reading the JIT developer documentation, a few small wordsmithing issues
> stood out (although this may be due to me not being a native english
> speaker).

I think it's more likely because *I* am not a native speaker ;)


> The attached patch fixes these to what I think the sentences inteded to say.

Thanks.  I'm not carrying my commit bit right here, so I'll try to
commit it later.

- Andres

  3. Re: JIT documentation fixes

    Peter Geoghegan <pg@bowt.ie> — 2018-06-09T17:05:01Z

    On Thu, May 31, 2018 at 11:50 AM, Daniel Gustafsson <daniel@yesql.se> wrote:
> When reading the JIT developer documentation, a few small wordsmithing issues
> stood out (although this may be due to me not being a native english speaker).
> The attached patch fixes these to what I think the sentences inteded to say.

Committed with a few adjustments.

I found that "an SQL..." was about as common as "a SQL..." in the
documentation. Either can be correct -- it depends on how you
pronounce "SQL". I didn't see any point in those changes, perhaps
because I always say "S-Q-L".

I'm also pretty sure that Andres did in fact mean "...even for faster
queries", since an LRU cache of JIT functions should be particularly
useful for OLTP queries that are already individually fast enough to
make per-execution JIT compilation overhead prohibitively expensive.
That change was also left out. If I'm mistaken in how I interpreted
the sentence, then Andres should follow up.

Thanks
-- 
Peter Geoghegan

  4. Re: JIT documentation fixes

    Daniel Gustafsson <daniel@yesql.se> — 2018-06-09T17:40:22Z

    > On 9 Jun 2018, at 19:05, Peter Geoghegan <pg@bowt.ie> wrote:
> 
> On Thu, May 31, 2018 at 11:50 AM, Daniel Gustafsson <daniel@yesql.se> wrote:
>> When reading the JIT developer documentation, a few small wordsmithing issues
>> stood out (although this may be due to me not being a native english speaker).
>> The attached patch fixes these to what I think the sentences inteded to say.
> 
> Committed with a few adjustments.

Thanks, I’m honoured to get the first commit.

> I'm also pretty sure that Andres did in fact mean "...even for faster
> queries", since an LRU cache of JIT functions should be particularly
> useful for OLTP queries that are already individually fast enough to
> make per-execution JIT compilation overhead prohibitively expensive.

Ah, I completely misunderstood that part (apparently) but that make sense.

cheers ./daniel

  5. Re: JIT documentation fixes

    Peter Geoghegan <pg@bowt.ie> — 2018-06-09T18:30:35Z

    On Sat, Jun 9, 2018 at 10:40 AM, Daniel Gustafsson <daniel@yesql.se> wrote:
> Thanks, I’m honoured to get the first commit.

Keep them coming.   :-)

-- 
Peter Geoghegan