Horton

Re: GUC names in messages

Alexander Law <exclusion@gmail.com>

View thread View on postgr.es
From: Alexander Lakhin <exclusion@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>, Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-09-04T16:00:00Z
Lists: pgsql-hackers 
Hello Peter,

[ sorry for the kind of off-topic ]

17.05.2024 14:57, Peter Eisentraut wrote:
> I committed your 0001 and 0002 now, with some small fixes.
>
> There has also been quite a bit of new code, of course, since you posted your patches, so we'll probably find a few 
> more things that could use adjustment.
>
> I'd be happy to consider the rest of your patch set after beta1 and/or for PG18.

While translating messages, I've encountered a weird message, updated by
17974ec25:
     printf(_("(in \"wal_sync_method\" preference order, except fdatasync is Linux's default)\n"));

Does "except ..." make sense here or it's just a copy-and-paste from docs?:
         The default is the first method in the above list that is supported
         by the platform, except that <literal>fdatasync</literal> is the default on
         Linux and FreeBSD.

Best regards,
Alexander

Commits

  1. Apply GUC name from central table in more places of guc.c

  2. Use camel case for "DateStyle" in some error messages

  3. Unify some error messages to ease work of translators

  4. Apply more quoting to GUC names in messages

  5. Revise GUC names quoting in messages again

  6. doc: Mention how to use quotes with GUC names in error messages

  7. Apply quotes more consistently to GUC names in logs