Horton

Re: On login trigger: take three

a.sokolov@postgrespro.ru

View thread View on postgr.es
From: a.sokolov@postgrespro.ru
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, Greg Nancarrow <gregn4422@gmail.com>, Ivan Panchenko <wao@mail.ru>, Teodor Sigaev <teodor@sigaev.ru>, Ibrar Ahmed <ibrar.ahmad@gmail.com>, vignesh C <vignesh21@gmail.com>, Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Amit Kapila <amit.kapila16@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>
Date: 2022-03-18T07:24:46Z
Lists: pgsql-hackers 
Daniel Gustafsson писал 2022-03-15 23:52:

> Yeah, that was the previously posted v25 from the author (who adopted 
> it from
> the original author).  I took the liberty to quickly poke at the review
> comments you had left as well as the ones that I had found to try and 
> progress
> the patch.  0001 should really go in it's own thread though to not hide 
> it from
> anyone interested who isn't looking at this thread.
Hi
I got an error while running tests on Windows:
2022-03-17 17:30:02.458 MSK [6920] [unknown] LOG:  no match in usermap 
"regress" for user "regress_user" authenticated as 
"vagrant@WINDOWS-2019"
2022-03-17 17:30:02.458 MSK [6920] [unknown] FATAL:  SSPI authentication 
failed for user "regress_user"
2022-03-17 17:30:02.458 MSK [6920] [unknown] DETAIL:  Connection matched 
pg_hba.conf line 2: "host all all 127.0.0.1/32  sspi include_realm=1 
map=regress"
2022-03-17 17:30:02.526 MSK [3432] FATAL:  could not receive data from 
WAL stream: server closed the connection unexpectedly
		This probably means the server terminated abnormally
		before or while processing the request.

I propose to make such correction:
--- a/src/test/recovery/t/001_stream_rep.pl
+++ b/src/test/recovery/t/001_stream_rep.pl
@@ -14,7 +14,7 @@ my $node_primary = get_new_node('primary');
  # and it needs proper authentication configuration.
  $node_primary->init(
         allows_streaming => 1,
-       auth_extra       => [ '--create-role', 'repl_role' ]);
+       auth_extra       => [ '--create-role', 'repl_role,regress_user' 
]);
  $node_primary->start;
  my $backup_name = 'my_backup';


-- 
Andrey Sokolov
Postgres Professional: http://www.postgrespro.com

Commits

  1. Fix some typos in event trigger docs

  2. Use heap_inplace_update() to unset pg_database.dathasloginevt

  3. Remove the flaky check in event_trigger_login regression test

  4. Fix instable 006_login_trigger.pl test

  5. Add support event triggers on authenticated login

  6. Add GUC for temporarily disabling event triggers

  7. Fix typo in reference to __FreeBSD__.

  8. Restore robustness of TAP tests that wait for postmaster restart.

  9. Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.