Re: [PATCH] Add tests for Bitmapset

Greg Burd <greg@burd.me>

From: Greg Burd <greg@burd.me>

To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Cc: Nathan Bossart <nathandbossart@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Michael Paquier <michael@paquier.xyz>, Robert Haas <robertmhaas@gmail.com>

Date: 2025-09-16T19:04:39Z

Lists: pgsql-hackers

Attachments

v4-0001-Add-a-module-that-tests-Bitmapset.patch (application/octet-stream) patch v4-0001

I've re-written the set of tests as suggested (I hope!).  I've not
re-run the coverage report (yet) to ensure we're at least as well
covered as v3, but attached is v4 for your inspection (amusement?). 
I've tried to author the SQL tests such that failures clearly indicate
what's at gone wrong.

This exercise turned into a lot more LOC than I'd expected, I hope it
provides some value to the community for testing this important data
structure and helps to codify the API clearly.

best.

-greg

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Minor fixes for test_bitmapset.c
- 5142f0093e64 19 (unreleased) landed
test_bitmapset: Improve random function
- 9d46b86529e8 19 (unreleased) landed
Add mem_exceeded_count column to pg_stat_replication_slots.
- d3b6183dd988 19 (unreleased) landed
Tidy-up unneeded NULL parameter checks from SQL function
- a69b55cd4727 19 (unreleased) landed
Remove check for NULL in STRICT function
- 381f5cffae00 19 (unreleased) landed
Fixes for comments in test_bitmapset
- a1b064e4b226 19 (unreleased) landed
Minor fixups of test_bitmapset.c
- 3a6615806859 19 (unreleased) landed
test_bitmapset: Simplify code of the module
- 9952f6c05a40 19 (unreleased) landed
test_bitmapset: Expand more the test coverage
- 5668fff3c512 19 (unreleased) landed
Fix compiler warnings in test_bitmapset
- f83fe65f3fc1 19 (unreleased) landed
Add a test module for Bitmapset
- 00c3d87a5cab 19 (unreleased) landed