Horton

Re: language cleanups in code and docs

David Steele <david@pgmasters.net>

View thread View on postgr.es
From: David Steele <david@pgmasters.net>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Date: 2020-07-08T21:09:42Z
Lists: pgsql-hackers 
On 7/8/20 4:39 PM, Andres Freund wrote:
> Hi,
> 
> I've pushed most of the changes.
> 
> On 2020-06-16 18:59:25 -0400, David Steele wrote:
>> On 6/16/20 6:27 PM, Andres Freund wrote:
>>> On 2020-06-16 17:14:57 -0400, David Steele wrote:
>>>> On 6/15/20 2:22 PM, Andres Freund wrote:
>>>
>>>>> 0008: docs: WIP multi-master rephrasing.
>>>>>      I like neither the new nor the old language much. I'd welcome input.
>>>>
>>>> Why not multi-primary?
>>>
>>> My understanding of primary is that there really can't be two things
>>> that are primary in relation to each other.
>>
>> Well, I think the same is true for multi-master and that's pretty common.
>>
>>> active/active is probably
>>> the most common term in use besides multi-master.
>>
>> Works for me and can always be updated later if we come up with something
>> better. At least active-active will be easier to search for.
> 
> What do you think about the attached?

I think this phrasing in the original/updated version is pretty awkward:

+  A standby server that cannot be connected to until it is promoted to a
+  primary server is called a ...

How about:

+ A standby server that must be promoted to a primary server before
+ accepting connections is called a ...

Other than that it looks good to me.

Regards,
-- 
-David
david@pgmasters.net

Commits

  1. Replace remaining uses of "whitelist".

  2. pgindent: whitelist/blacklist -> additional/excluded.

  3. Rename "enum blacklist" to "uncommitted enums".

  4. code: replace most remaining uses of 'master'.

  5. docs: replace 'master process' with 'supervisor process' where appropriate.

  6. docs: replace 'master' with 'root' where appropriate.

  7. docs: replace 'master' with 'primary' where appropriate.

  8. code: replace 'master' with 'leader' where appropriate.

  9. code: replace 'master' with 'primary' where appropriate.

  10. tap tests: replace 'master' with 'primary'.