Horton
Menu

Re: BUG #18831: Particular queries using gin-indexes are not interruptible, resulting is resource usage concerns.

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Vinod Sridharan <vsridh90@gmail.com>
Cc: niek.brasa@hitachienergy.com, pgsql-bugs@lists.postgresql.org
Date: 2025-04-12T16:40:28Z
Lists: pgsql-bugs 
Vinod Sridharan <vsridh90@gmail.com> writes:
> I managed to get a test that fails without my patch, and added it to
> the intarray tests. Without the patch, the query returns 0 records.
> With my patch, the results are correct (12 records).

Cool, thanks.

> Please find attached the updated patch with a fix & a test in the
> intarray contrib. Thanks for the pointer to the contrib extensions.

Pushed with light editorialization.  I noticed one other bug in the
same area: shimTriConsistentFn wasn't paying attention to the recheck
flag returned by its first call to the underlying consistentFn.
I think this is probably just a latent issue, because if any of the
later calls return recheck = true we'll end with the correct
result anyway.  And at least for the contrib modules that depend
on this, the recheck flag doesn't depend on the key-presence inputs.
But it's theoretically possible we'd get the wrong answer.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix GIN's shimTriConsistentFn to not corrupt its input.

  2. Fix some performance issues in GIN query startup.