Horton

Re: basic_archive lost archive_directory

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Sergei Kornilov <sk@zsrv.org>, Олег Самойлов <splarv@ya.ru>, pgsql-bugs@lists.postgresql.org, Álvaro Herrera <alvherre@kurilemu.de>
Date: 2026-02-23T22:22:15Z
Lists: pgsql-bugs 
Nathan Bossart <nathandbossart@gmail.com> writes:
> On Wed, Feb 11, 2026 at 03:14:15PM -0600, Nathan Bossart wrote:
>> On Tue, Feb 10, 2026 at 10:06:25AM -0600, Nathan Bossart wrote:
>>> As I mentioned upthread, IMHO we should simply remove the existence check
>>> from the GUC check hook.  basic_archive must already be written to handle
>>> the archive directory disappearing at any moment, so we should be able to
>>> rely on it without the extra stat().

> Any thoughts?  I'll wait another week or so, but then will proceed with
> committing/back-patching this.

Agreed --- this seems like a pretty inappropriate check to be making
in a check_hook.

			regards, tom lane

Commits

  1. basic_archive: Allow archive directory to be missing at startup.