Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-11-19T00:50:09Z
Lists: pgsql-hackers
Masahiko Sawada <sawada.mshk@gmail.com> writes: > On Mon, Nov 18, 2024 at 3:41 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote: >> While we're at it, I noticed that lib/radixtree.h includes "postgres.h". >> That's against our usual convention. > Good catch. I've updated the patch accordingly. Probably out of scope for this particular patch, but it occurred to me to grep for other similar violations, and I found three: src/bin/pg_combinebackup/copy_file.h:#include "c.h" src/include/fe_utils/option_utils.h:#include "postgres_fe.h" src/include/fe_utils/query_utils.h:#include "postgres_fe.h" regards, tom lane
Commits
-
Include necessary header files in radixtree.h.
- 724890ffb75c 18.0 landed
- a12b0f3a9dc0 17.3 landed