Re: recent deadlock regression test failures
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kevin Grittner <kgrittn@gmail.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>,
Andres Freund <andres@anarazel.de>,
Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-04-09T00:53:54Z
Lists: pgsql-hackers
... BTW, one other minor coding suggestion for GetSafeSnapshotBlockingPids(): it might be better to avoid doing so much palloc work while holding the SerializableXactHashLock. Even if it's only held shared, I imagine that it's a contention bottleneck. You could avoid that by returning an array rather than a list; the array could be preallocated of size MaxBackends before ever taking the lock. That would be a little bit space-wasteful, but since it's only short-lived storage it doesn't seem like much of a problem. regards, tom lane
Commits
-
Move isolationtester's is-blocked query into C code for speed.
- 511540dadf11 10.0 landed