Re: pg_parameter_aclcheck() and trusted extensions

On 7/7/22 15:00, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> On Thu, Jul 07, 2022 at 12:41:00PM -0400, Tom Lane wrote:
>>> Can we get away with doing these things in beta3?  We could avoid
>>> breaking (2) in the v15 branch by making set_config_option into
>>> a wrapper around set_config_option_ext, or something like that;
>>> but the problem with struct config_generic seems inescapable.
> 
>> I personally lean more towards the compatibility break than reverting the
>> feature.  There are still a couple of months before 15.0, and I suspect it
>> won't be too difficult to fix any extensions that break because of this.
> 
> I checked http://codesearch.debian.net and found only a couple of
> extensions that #include guc_tables.h at all, so I'm satisfied
> that the struct config_generic ABI issue is tolerable.  Recompiling
> after beta3 would be enough to fix any problem there, and it's
> hard to believe that anyone is trying to ship production-ready
> v15 extensions already.

There are a handful here as well:

https://github.com/search?q=guc_tables.h+and+PG_MODULE_MAGIC&type=Code&ref=advsearch&l=&l=

But as one of the affected authors I would say recompiling after beta3 
is fine.

> The aspect that is a bit more debatable is whether to trouble with
> a set_config_option() wrapper to avoid the API break in v15.
> I think we'd still be making people deal with an API break in v16,
> so making them do it this year rather than next doesn't seem like
> a big deal ... but maybe someone wants to argue it's too late
> for API breaks in v15?

Well there are other API breaks that affect me in v15, and to be honest 
I have done little except keep an eye out for the ones likely to affect 
extensions I maintain so far, so may as well inflict the pain now as 
later ¯\_(ツ)_/¯

Joe
-- 
Joe Conway
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com