Horton

Thread

Commits

  1. Fixup various StringInfo function usages

  1. Fixup some StringInfo usages

    David Rowley <dgrowleyml@gmail.com> — 2024-04-09T00:53:21Z

    Similar to f736e188c, I've attached a patch that fixes up a few
misusages of the StringInfo functions. These just swap one function
call for another function that is more suited to the use case.

I've also attached the patch that I used to find these.  That's not
intended for commit.

I feel like it's a good idea to fix these soon while they're new
rather than wait N years and make backpatching bug fixes possibly
harder.

I've attached a file with git blame commands to identify where all of
these were introduced.  All are new to PG17.

Any objections?

David

  2. Re: Fixup some StringInfo usages

    Nathan Bossart <nathandbossart@gmail.com> — 2024-04-09T01:34:12Z

    On Tue, Apr 09, 2024 at 12:53:21PM +1200, David Rowley wrote:
> Similar to f736e188c, I've attached a patch that fixes up a few
> misusages of the StringInfo functions. These just swap one function
> call for another function that is more suited to the use case.
> 
> I've also attached the patch that I used to find these.  That's not
> intended for commit.
> 
> I feel like it's a good idea to fix these soon while they're new
> rather than wait N years and make backpatching bug fixes possibly
> harder.
> 
> I've attached a file with git blame commands to identify where all of
> these were introduced.  All are new to PG17.
> 
> Any objections?

Looks reasonable to me.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

  3. Re: Fixup some StringInfo usages

    Tom Lane <tgl@sss.pgh.pa.us> — 2024-04-09T02:27:36Z

    David Rowley <dgrowleyml@gmail.com> writes:
> Similar to f736e188c, I've attached a patch that fixes up a few
> misusages of the StringInfo functions. These just swap one function
> call for another function that is more suited to the use case.

> I feel like it's a good idea to fix these soon while they're new
> rather than wait N years and make backpatching bug fixes possibly
> harder.

+1.  Looks good in a quick eyeball scan.

			regards, tom lane

  4. Re: Fixup some StringInfo usages

    David Rowley <dgrowleyml@gmail.com> — 2024-04-09T23:57:20Z

    On Tue, 9 Apr 2024 at 14:27, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> David Rowley <dgrowleyml@gmail.com> writes:
> > Similar to f736e188c, I've attached a patch that fixes up a few
> > misusages of the StringInfo functions. These just swap one function
> > call for another function that is more suited to the use case.
>
> > I feel like it's a good idea to fix these soon while they're new
> > rather than wait N years and make backpatching bug fixes possibly
> > harder.
>
> +1.  Looks good in a quick eyeball scan.

Thank you to both of you for having a look. Pushed.

David