Horton

Re: Using Valgrind to detect faulty buffer accesses (no pin or buffer content lock held)

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>, Daniel Gustafsson <daniel@yesql.se>, Andres Freund <andres@anarazel.de>, Alvaro Herrera <alvherre@2ndquadrant.com>, Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-07-19T02:36:36Z
Lists: pgsql-hackers 
Peter Geoghegan <pg@bowt.ie> writes:
> On Thu, Jul 16, 2020 at 10:24 AM Anastasia Lubennikova
> <a.lubennikova@postgrespro.ru> wrote:
>> Other than that, patches look good to me, so move them to "Ready For
>> Committer".

> Pushed the first patch just now, and intend to push the other one soon. Thanks!

I wonder whether skink's failure today is due to this change:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2020-07-18%2018%3A01%3A10

			regards, tom lane

Commits

  1. Add nbtree Valgrind buffer lock checks.

  2. Add Valgrind buffer access instrumentation.

  3. Fix bug in nbtree VACUUM "skip full scan" feature.

  4. Fix another minor page deletion buffer lock issue.

  5. Fix minor nbtree page deletion buffer lock issue.

  6. Skip full index scan during cleanup of B-tree indexes when possible