Re: Logging corruption error codes
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andrey Borodin <x4mmm@yandex-team.ru>, pgsql-bugs@lists.postgresql.org, Анна Крханбарова <annkpx@yandex-team.ru>, Dmitriy Sarafannikov <dsarafan@yandex-team.ru>
Date: 2019-07-22T11:16:21Z
Lists: pgsql-bugs
On 2019-06-20 11:57, Andrey Borodin wrote: > We are fine-tuning our data corruption monitoring and found out that many corruption cases do not report proper error code. > This makes automatic log analyzer way too smart program. > We think that corruption error codes should be given in cases when B-tree or TOAST do not know how to interpret data. > PFA patch with cases that we have found in logs and consider evidence of corruption. > > Best regards, Andrey Borodin. Should we use errmsg_internal() in the adjusted calls, so that the error messages are not picked up for translation? I could go either way, but it's something that should be considered. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Add error codes to some corruption log messages
- fd6ec93bf890 13.0 landed