Re: BUG #18348: Inconsistency with EXTRACT([field] from INTERVAL);
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: work.michael.2956@gmail.com, pgsql-bugs@lists.postgresql.org,
Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Date: 2024-02-17T18:14:19Z
Lists: pgsql-bugs, pgsql-hackers
Attachments
- 0001-update-extract-description.patch (text/x-diff) patch 0001
- 0002-condense-century-discussion.patch (text/x-diff) patch 0002
David Rowley <dgrowleyml@gmail.com> writes: > On Sat, 17 Feb 2024 at 01:27, PG Bug reporting form > <noreply@postgresql.org> wrote: >> Moreover, the documentation does not mention that the field cannot be >> extracted from INTERVAL, like it does for isoyear: >> https://www.postgresql.org/docs/current/functions-datetime.html#FUNCTIONS-DATETIME-EXTRACT > Maybe that table should specify which type(s) each of the items listed > is applicable to. Seems better than mentioning which types they're not > applicable to. The thing's not laid out as a table though, and converting it seems like more trouble than this is worth. The rejected cases hardly seem surprising. I propose just mentioning that not all fields apply for all data types, as in 0001 attached. (Parenthetically, one case that perhaps is surprising is ERROR: unit "week" not supported for type interval Why not just return the day field divided by 7?) Unrelated but adjacent, the discussion of the century field seems more than a bit flippant when I read it now. In other places we are typically content to use examples to make similar points. I propose doing so here too, as in 0002 attached. Lastly, the entire page is quite schizophrenic about whether to leave a blank line between adjacent examples. I could go either way on whether to have that whitespace or not, but I do think it would be better to make it uniform. Any votes on what to do there? regards, tom lane
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Fix extraction of week and quarter fields from intervals.
- 6be39d77a70d 18.0 landed
-
Doc: improve explanation of type interval, especially extract().
- fcd210d496da 17.0 landed
- ebf52e9b7532 14.12 landed
- eb1d008a7a18 13.15 landed
- 6d03e8109250 15.7 landed
- 3ad319b8cad4 16.3 landed