Horton

Re: Serverside SNI support in libpq

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Zsolt Parragi <zsolt.parragi@percona.com>, Michael Banck <mbanck@gmx.net>, Jacob Champion <jacob.champion@enterprisedb.com>, Jelte Fennema-Nio <postgres@jeltef.nl>, Heikki Linnakangas <hlinnaka@iki.fi>, "li.evan.chao" <li.evan.chao@gmail.com>, Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>, Pgsql Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-05-04T22:00:02Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Declare load_hosts() as returning HostsFileLoadResult.

Daniel Gustafsson <daniel@yesql.se> writes:
>> On 4 May 2026, at 21:22, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> As a side matter, "load_host" seems like a remarkably generic name
>> that conveys little about what it actually does,

> It's following the naming convention of load_hba() which reads pg_hba.conf, and
> load_ident() which reads pg_ident.conf - thus load_hosts() for the function
> that reads pg_hosts.conf.  Perhaps load_pg_hosts_conf() or load_hosts_config()
> would convey more meaning?

Hmm, okay.  I'd prefer a more specific name, but it wouldn't make
much sense unless we also rename those two.  That's probably more
code churn than is justified.

I'll push the thing for moving/using the typedef, but leave the
function name alone.

			regards, tom lane