Re: pg_subscription.subslotname is wrongly marked NOT NULL

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: pgsql-hackers@lists.postgresql.org

Date: 2020-07-19T23:48:18Z

Lists: pgsql-hackers

Attachments

fix-srsublsn-usage-for-nullness.patch (text/x-diff) patch

I wrote:
> pg_subscription_rel.srsublsn also needs to be marked nullable.

Not only is it wrongly marked attnotnull, but two of the three places
that read it are doing so unsafely (ie, as though it *were*
non-nullable).  So I think we'd better fix it as attached.

			regards, tom lane

Commits

Assert that we don't insert nulls into attnotnull catalog columns.
- fb71329ad6fc 10.14 landed
- f451029db85a 11.9 landed
- bca409e5b160 13.0 landed
- 43ef3c4c360a 12.4 landed
- 3e66019f1554 14.0 landed
Avoid direct C access to possibly-null pg_subscription_rel.srsublsn.
- ae3d40b0cdc6 10.14 landed
- 99b0c5da3e10 11.9 landed
- b7103bbe34aa 12.4 landed
Kluge slot_compile_deform() to ignore incorrect attnotnull markings.
- 855195a7ba98 11.9 landed
- 798b4faefd20 12.4 landed
Correctly mark pg_subscription_rel.srsublsn as nullable.
- e5372b48b94f 13.0 landed
- 0fa0b487b5d7 14.0 landed
Correctly mark pg_subscription.subslotname as nullable.
- 914d2383ae91 13.0 landed
- 72eab84a565c 14.0 landed