Re: Cleanup: remove unused fields from nodes
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
Etsuro Fujita <etsuro.fujita@gmail.com>,
Amit Kapila <amit.kapila16@gmail.com>
Date: 2024-04-24T12:31:57Z
Lists: pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Apr 23, 2024 at 11:03:40PM -0400, Tom Lane wrote:
>> Hah. Seems like the comment for isall needs to explain that it
>> exists for this purpose, so we don't make this mistake again.
> How about something like the attached?
I was thinking about wording like
* True if DEALLOCATE ALL. This is redundant with "name == NULL",
* but we make it a separate field so that exactly this condition
* (and not the precise name) will be accounted for in query jumbling.
regards, tom lane
Commits
-
Improve comment of DeallocateStmt->isall
- ee3ef4af19d8 17.0 landed
-
Remove some unnecessary fields from executor nodes.
- b7d35d393edb 17.0 landed
-
Add SQL/JSON query functions
- 6185c9737cf4 17.0 cited
-
Add support for doing late row locking in FDWs.
- afb9249d06f4 9.5.0 cited