Horton

Re: [PATCH] Add min() and max() aggregate functions for xid8

Ken Kato <katouknl@oss.nttdata.com>

View thread View on postgr.es
From: Ken Kato <katouknl@oss.nttdata.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-02-08T09:43:18Z
Lists: pgsql-hackers

Attachments

On 2022-02-08 15:34, Fujii Masao wrote:
> Thanks for updating the patch! It basically looks good to me. I
> applied the following small changes to the patch. Updated version of
> the patch attached. Could you review this version?

Thank you for the patch!

It looks good to me!

I'm not sure how strict coding conventions are, but the following line 
is over 80 characters.
+insert into xid8_t1 values ('0'), ('010'), ('42'), 
('0xffffffffffffffff'), ('-1');
Therefore, I made a patch which removed ('010') just to fit in 80 
characters.


Best wishes,

-- 
Ken Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. Add min() and max() aggregates for xid8.