Re: Add Postgres module info
Andrei Lepikhov <lepihov@gmail.com>
From: Andrei Lepikhov <lepihov@gmail.com>
To: Yurii Rashkovskii <yrashk@omnigres.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-12-27T01:34:00Z
Lists: pgsql-hackers
On 12/24/24 10:42, Yurii Rashkovskii wrote: > On Mon, Dec 16, 2024 at 12:02 PM Andrei Lepikhov <lepihov@gmail.com > I've reviewed the patch, and it is great that you support more flexible > versioning now. I am just wondering a bit about the case where `minfo- > >name` can be `NULL` but `minfo->version` isn't, or where both are > `NULL` – should we skip any of these? Depends. I wrote code that way so as not to restrict a maintainer by initialising all the fields; remember, it may grow in the future. But I am open to changing that logic. Do you have any specific rule on which fields may be empty and that must be initialised? Do you think all fields maintainer must fill with non-zero-length constants? Also, I've added this patch to commitfest: https://commitfest.postgresql.org/51/5465/ -- regards, Andrei Lepikhov
Commits
-
Avoid mixing designated and non-designated field initializers.
- d66997dfe8fe 18.0 landed
-
Use PG_MODULE_MAGIC_EXT in our installable shared libraries.
- 55527368bd07 18.0 landed
-
Introduce PG_MODULE_MAGIC_EXT macro.
- 9324c8c58065 18.0 landed