Re: Command Triggers, patch v11

Andres Freund <andres@anarazel.de>

From: "anarazel@anarazel.de" <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org, Thom Brown <thom@linux.com>, Dimitri Fontaine <dimitri@2ndquadrant.fr>
Date: 2012-02-28T00:29:20Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Fix SPGiST vacuum algorithm to handle concurrent tuple motion properly.

  2. Remove useless const qualifier

  3. Make executor's SELECT INTO code save and restore original tuple receiver.


Tom Lane <tgl@sss.pgh.pa.us> schrieb:

>Andres Freund <andres@anarazel.de> writes:
>> I refreshed the patch so it works again on current HEAD. Basically
>some 
>> trivial fixes and dfd26f9c5f371437f243249025863ea9911aacaa. The
>latter doesn't 
>> seem necessary to me after the changes, so I simply ditched it. Am I
>missing 
>> something?
>
>No, that was only needed because execMain.c was overriding somebody
>else's tuple receiver.  If you're putting the right receiver into the
>QueryDesc to start with, it shouldn't be necessary.
>
>I'm confused by this though:
>
>> This basically includes a revert of
>d8fb1f9adbddd1eef123d66a89a9fc0ecd96f60b
>
>I don't find that commit ID anywhere.
That should have been the aforementioned commit. Must have screwed up the copy&paste buffer. Sorry for that.

Andres

Please excuse the brevity and formatting - I am writing this on my mobile phone.