Horton

Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>, "David E. Wheeler" <david@justatheory.com>, Mankirat Singh <mankiratsingh1315@gmail.com>, pg@bowt.ie, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
Date: 2025-10-31T15:17:11Z
Lists: pgsql-hackers 
Nathan Bossart <nathandbossart@gmail.com> writes:
> On Fri, Oct 31, 2025 at 12:02:10PM +0100, Peter Eisentraut wrote:
>> What is the reason that this file is supposed to contain the history of
>> relevant changes, rather than just the last one?
>> If you want the history, you could look at the git log of the file itself,
>> no?

> I think either way would ultimately be fine.  I might argue that keeping
> the full history in a file with detailed explanations is more accessible
> than requiring folks to run
> 	git log .abi-compliance-history
> (Plus, if someone doesn't bother to put details in the commit message, you
> then have to sleuth further to figure out what changed.)

Yeah, that last.  I would expect the annotation text in
.abi-compliance-history to be specific about the nature of the ABI
break, whereas the log message for the commit that changed things
might not bother with such details.

As we move along with this effort, we might ultimately decide that
this scheme is overdoing the amount of detail recorded.  But to
start with, I'd rather err on the side of recording more info
not less.

			regards, tom lane

Commits

  1. Add commit 24f6c1bd4 to v17 .abi-compliance-history.

  2. Add .abi-compliance-history to back-branches.

  3. Add reminder to create .abi-compliance-history.

  4. Update .abi-compliance-history file.

  5. Add .abi-compliance-history to v18 branch.

  6. Fix thinko in commit 7d129ba54.

  7. Fix lookups in pg_{clear,restore}_{attribute,relation}_stats().

  8. Add defenses against unexpected changes in the NodeTag enum list.