Horton

Re: pg_dump: sortDumpableObjectsByTypeName() doesn't always do that

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <pchampion@pivotal.io>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-08-06T19:13:06Z
Lists: pgsql-hackers 
Jacob Champion <pchampion@pivotal.io> writes:
> We recently ran into an issue in pg_dump that caused the initial
> sort-by-name pass to return incorrect results. It doesn't seem to
> affect overall correctness, since the later toposort pass takes care
> of dependencies, but it does occasionally cause a spurious diff in
> dump output before and after a pg_upgrade run.

Do you mean "incorrect results", or just "unstable results"?
If the former, what's incorrect about it?

			regards, tom lane

Commits

  1. Ensure pg_dump_sort.c sorts null vs non-null namespace consistently.

  2. Last-minute updates for release notes.